search

OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another
GNU Affero General Public License v3.0
123 stars 112 forks source link

Apply pre commit #55

Closed joao-p-marques closed 3 years ago

joao-p-marques commented 3 years ago

Part of what https://github.com/OCA/odoo-module-migrator/pull/41 is implementing

This PR takes some of the work already done, and adds some fixes and the suggested option of skipping pre-commit execution.

I also rebased to fix conflicts.

This should make both PRs easier to review as #41 tries to implement 2 big functionalities.

ping @Yajo @sebastienbeau @legalsylvain

yajo commented 3 years ago

Check travis.

joao-p-marques commented 3 years ago

Check travis.

Thanks, should be fixed now :+1:

legalsylvain commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

On my way to merge this fine PR! Prepared branch master-ocabot-merge-pr-55-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at c32d5a20e41914c158e462dbba8e45cf414451bb. Thanks a lot for contributing to OCA. ❤️

joao-p-marques commented 3 years ago

Merging PRs here is fast as nowhere in OCA

Also, merging a PR here can take from 5 minutes to a couple of months, so not the fastest in OCA :sweat_smile: