search

OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another
GNU Affero General Public License v3.0
123 stars 112 forks source link

[IMP] make remove migration folder optional #58

Closed jjscarafia closed 2 years ago

jjscarafia commented 2 years ago

Using odoo upgrade service and skiping versions, it's useful for previous migration scripts to remain there.

Maybe this is not ok for OCA repositories but can be used on custom repositories.

jjscarafia commented 2 years ago

hi @pedrobaeza ! thanks for the review. I understand that in OCA modules they need to be deleted but this tool is not only used for OCA repos. That's why I make it optional and by default it keep working as it was (deleting the migration folder).

If this tool is only for OCA repos then ok, I get it, but then I believe we should removed other optional features.

Thanks

jjscarafia commented 2 years ago

exactly, by default keep deleting, thanks @pedrobaeza

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain commented 2 years ago

/ocabot merge patch

OCA-git-bot commented 2 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch master-ocabot-merge-pr-58-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at d10d122de724743d08d681c29e2145c6e088c8a4. Thanks a lot for contributing to OCA. ❤️