search

OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another
GNU Affero General Public License v3.0
123 stars 112 forks source link

[ADD] read_group refactor script #82

Closed bruno-zanotti closed 9 months ago

jjscarafia commented 9 months ago

/ocabot merge nobump

OCA-git-bot commented 9 months ago

On my way to merge this fine PR! Prepared branch master-ocabot-merge-pr-82-by-jjscarafia-bump-nobump, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at b351ec476c130b474698e9a8dbc09e52d5cadade. Thanks a lot for contributing to OCA. ❤️

bruno-zanotti commented 6 months ago

Next time, please provide a meaningful description, because this change has no rationale.

This PR was made during the OCA Days and we discuss about this in the event, that's why it was merge without description. Anyway is not a change it self, we are just adding an script to handle the migration of the read_group method that has changes in v17 (more info: https://github.com/odoo/odoo/pull/110737)

luisg123v commented 6 months ago

@Bruno-Zanotti thanks for the reference, it was very useful.

I am the opinion commits shouldn't have empty messages unless they are very obvious by reading the title.

In this case, a simple "for more info, (Odoo link)" would've been enough IMHO.

Regards,