Closed sbejaoui closed 1 year ago
@sbejaoui No menu to manage attribute groups, and it's not possible to create one from the attribute form since the field is declared with 'no create' into the form. Strange to see that views (form, tree and search) are declared but not available into the menu...
thanks @lmignon for the review.
It's weird that this object didn't have a menu item in all previous versions. I added the menu and the view_mode form to attribute_attribute_sort_action.
@sbejaoui Can you fix conflict please?
@sbejaoui Can you fix conflict please or if someone can do the fix @acsonefho
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot migration attribute_set
Suggestions for commits' rewrite:
[IMP] - set context for native fields
-> [IMP] attribute_set: set ctx for native fields
[FIX] - fix menu position
-> [FIX] attribute_set: fix menu position
[IMP] - add menu item for attribute group
- > [IMP] attribute_set: add group menu item
[IMP] - improve code and documentation
-> [IMP] attribute_set: misc improvements
Also, I took over #132 and replaced it w/ #169 to speed it up. Could you pls drop the commit from 132 and pick the one from 169? Merci!
Suggestions for commits' rewrite:
[IMP] - set context for native fields
->[IMP] attribute_set: set ctx for native fields
[FIX] - fix menu position
->[FIX] attribute_set: fix menu position
[IMP] - add menu item for attribute group
- >[IMP] attribute_set: add group menu item
[IMP] - improve code and documentation
->[IMP] attribute_set: misc improvements
Also, I took over #132 and replaced it w/ #169 to speed it up. Could you pls drop the commit from 132 and pick the one from 169? Merci!
done,
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-141-by-simahawk-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 42cbe9be208babee5943d18a52467a95d7873304. Thanks a lot for contributing to OCA. ❤️
includes:
132