OCA / odoo-pim

GNU Affero General Public License v3.0
39 stars 61 forks source link

[16.0][MIG] attribute_set #141

Closed sbejaoui closed 1 year ago

sbejaoui commented 1 year ago

includes:

sbejaoui commented 1 year ago

@sbejaoui No menu to manage attribute groups, and it's not possible to create one from the attribute form since the field is declared with 'no create' into the form. Strange to see that views (form, tree and search) are declared but not available into the menu...

thanks @lmignon for the review.

It's weird that this object didn't have a menu item in all previous versions. I added the menu and the view_mode form to attribute_attribute_sort_action.

acsonefho commented 1 year ago

@sbejaoui Can you fix conflict please?

cyrilmanuel commented 1 year ago

@sbejaoui Can you fix conflict please or if someone can do the fix @acsonefho

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk commented 1 year ago

/ocabot migration attribute_set

simahawk commented 1 year ago

Suggestions for commits' rewrite:

[IMP] - set context for native fields -> [IMP] attribute_set: set ctx for native fields [FIX] - fix menu position -> [FIX] attribute_set: fix menu position [IMP] - add menu item for attribute group - > [IMP] attribute_set: add group menu item [IMP] - improve code and documentation -> [IMP] attribute_set: misc improvements

Also, I took over #132 and replaced it w/ #169 to speed it up. Could you pls drop the commit from 132 and pick the one from 169? Merci!

sbejaoui commented 1 year ago

Suggestions for commits' rewrite:

[IMP] - set context for native fields -> [IMP] attribute_set: set ctx for native fields [FIX] - fix menu position -> [FIX] attribute_set: fix menu position [IMP] - add menu item for attribute group - > [IMP] attribute_set: add group menu item [IMP] - improve code and documentation -> [IMP] attribute_set: misc improvements

Also, I took over #132 and replaced it w/ #169 to speed it up. Could you pls drop the commit from 132 and pick the one from 169? Merci!

done,

simahawk commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-141-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 42cbe9be208babee5943d18a52467a95d7873304. Thanks a lot for contributing to OCA. ❤️