search

OCA / odoo-pim

GNU Affero General Public License v3.0
39 stars 60 forks source link

[16.0][MIG] product_attribute_set #142

Closed sbejaoui closed 11 months ago

GuillemCForgeFlow commented 1 year ago

Hi @sbejaoui, I've added some improvements here: https://github.com/OCA/odoo-pim/pull/125. Could you also add them here? Thank you 😄

simahawk commented 1 year ago

@sbejaoui just a reminder: - in the commit msg are not needed :wink:

simahawk commented 1 year ago

/ocabot migration product_attribute_set

victorvermot commented 1 year ago

@sbejaoui Could you attend to simahawk's comments and rebase PR ? Ty in advance

rousseldenis commented 1 year ago

I've added a dependency on #171 to remove domain from view (as it causes access rights problems for normal users)

lmignon commented 11 months ago

@rousseldenis https://github.com/OCA/odoo-pim/pull/171 is merged.. This one is ready to be merged

simahawk commented 11 months ago

/ocabot merge minor

OCA-git-bot commented 11 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-142-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot commented 11 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 11 months ago

Congratulations, your PR was merged at e8446f8635ccf504ab954f51c9187b880c9da74e. Thanks a lot for contributing to OCA. ❤️