OCA / odoo-pim

GNU Affero General Public License v3.0
39 stars 60 forks source link

[FIX] attribute_set: Force load of attributes #170

Closed lmignon closed 6 months ago

lmignon commented 1 year ago

Add all the attributes defined for the model into the list of fields to load to display the form view. Wihout this change a JS error occurs when displaying the form view of a x2many field for a model defining attributes. The origin of the error comes from the the get_views method which is called for the type 'form' only. In this case it's important to add all the custom attributes to the list of fields defined on the model for the view. When the same method is called without restriction it will load all the views. Since odoo include all the fields defined on the model for the search view, the error doesn't occur when using the form view from a menu action.

lmignon commented 1 year ago

ping @sbejaoui

simahawk commented 12 months ago

@lmignon both commits are into #171 I guess we can close this one as the other one is getting merged, right?

github-actions[bot] commented 8 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.