search

OCA / odoo-pre-commit-hooks

Linters of Odoo addons that complement pylint-odoo
GNU Affero General Public License v3.0
10 stars 12 forks source link

[FIX] unwanted execution of globally disabled checks #105

Closed ivantodorovich closed 2 months ago

ivantodorovich commented 2 months ago

If some checks were disabled inline on a file, the global disabled checks were ignored and possibly executed.

This is likely a regression since d7753c87, where the is_message_enabled was refactorized and this condition was changed.

moylop260 commented 2 months ago

@antonag32 @luisg123v

Could you review it, please?

antonag32 commented 2 months ago

Makes sense to me, does seem like the original code (which I think I wrote hehe) was buggy.

ivantodorovich commented 2 months ago

Thanks, guys!

I've just pushed an update to solve the missing update-readme issue