search

OCA / odoo-pre-commit-hooks

Linters of Odoo addons that complement pylint-odoo
GNU Affero General Public License v3.0
9 stars 11 forks source link

Pending TODO: Using uppercase extension for files in hooks.yaml? #60

Open antonag32 opened 1 year ago

antonag32 commented 1 year ago

I don't think we should let TODOs exist for too long (I personally believe they should not be committed to main), and while browsing the code I found this existing TODO:

- id: oca-checks-odoo-module
  name: Checks for Odoo modules
  description: Multiple checks for Odoo modules
  entry: oca-checks-odoo-module
  args: []
  language: python
  types_or: ["csv", "python", "xml"]
  # TODO: Check if should consider uppercase extension
  files: \.(csv|xml)$|/\_\_(manifest|openerp)\_\_.py$

If I understand correctly, currently mymodule.xml will be passed on to the hook, but mymodule.XML won't. I think this is fine but we might as well settle the debate to end this TODO.