OCA / odoo-pre-commit-hooks

Linters of Odoo addons that complement pylint-odoo
GNU Affero General Public License v3.0
10 stars 12 forks source link

Wrote documentation for proposed refactoring #66

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

There have been previous talks about refactoring source code in this repository. This is my proposal. It is based on a single Abstract Class (supported by a Message data class) which all linters will inherit from. My main goals are:

  1. Standardize arguments and common behavior across most if not all linters.
  2. Increase code reusability
  3. Propose an Architecture which brings performance benefits, reduced development time and helps solve actual (and future) issues.

This is a middle ground between two options that were previously discussed:

Checks will be separated into tools based on:

The .md file contains all details about the proposed change.

antonag32 commented 1 year ago

@moylop260 Can you review the proposal and tell me what you think please?