search

OCA / odoo-pre-commit-hooks

Linters of Odoo addons that complement pylint-odoo
GNU Affero General Public License v3.0
9 stars 11 forks source link

[IMP] add xml-oe-structure-missing-id check #78

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

Closes #27.

This checks generates a message whenever a tag with 'oe_structure' in its classes has no id attribute.

antonag32 commented 1 year ago

Can you review @moylop260 @luisg123v

antonag32 commented 1 year ago

Thanks for the review @luisg123v, I've made the corrections

moylop260 commented 1 year ago

@luisg123v

Could you re-check it, please?

luisg123v commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

Sorry @luisg123v you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

luisg123v commented 1 year ago

Don't blame me for trying :smile:

moylop260 commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch main-ocabot-merge-pr-78-by-moylop260-bump-nobump, awaiting test results.