[REF] Don't filter out messages, move is_message_enabled

OCA / odoo-pre-commit-hooks

Linters of Odoo addons that complement pylint-odoo

GNU Affero General Public License v3.0

10 stars 12 forks source link

[REF] Don't filter out messages, move is_message_enabled #83

Closed antonag32 closed 1 year ago

antonag32 commented 1 year ago

Related to #77.

Messages are no longer filtered out. Instead they are not generated in the first place. This prevents subtle bugs from being introduced, where a check is run (unwanted) and no one notices it because its messages are filtered out. It also simplifies the program's flow and avoids useless execution.
is_message_enabled has been moved to BaseChecker, this makes code easier and removes redundancy since the same enable, disable sets were being passed around constantly.

antonag32 commented 1 year ago

@moylop260 @luisg123v Can you review?

After internal discussion it seems like we won't be focusing on merging config sources for the time being, so only this set of changes related to the issue will remain.