OCA / odoorpc

Python module to pilot your Odoo servers through JSON-RPC.
http://pythonhosted.org/OdooRPC/
GNU Lesser General Public License v3.0
231 stars 123 forks source link

[UPD] travis: test v13 and v14 #60

Closed MiquelRForgeFlow closed 3 years ago

MiquelRForgeFlow commented 3 years ago

To check if something needs to be fixed.

MiquelRForgeFlow commented 3 years ago

Hello @sebalix

Here are some nice improvements:

What is pending:

What we obtain:

I would like you to merge this, and then later, in future PRs, try to fix those pending errors.

Selection_042

sebalix commented 3 years ago

I already struggle with the issue regarding the v12 build, I don't think I want to pass more time on it... maybe we could disable the tests for v12 to get a green build, this version won't change anymore I suppose, if v11 and v13 builds are green, it's OK to say that the v12 is supported as well by the project.

MiquelRForgeFlow commented 3 years ago

Yeah, the issue with v12 is due to https://github.com/odoo/odoo/blob/12.0/addons/account/models/chart_template.py#L177 with an unexpected falsy company. But disabling tests for v12, that would mean disabling a lot of tests, because many tests depend of that part. An alternative could be installing instead a module that not depends of account and adapt the tests.

sebalix commented 3 years ago

I try to be pragmatic with my time, if you want to fix it you are welcome :) Sadly I don't think I'll be able to pass more time on this issue, especially if we need to install other modules than sale+account to get working tests it'll be difficult.

Anyway, big thanks for your updates! Regarding the issue for v14 _render, we could try to use the HTTP controller to generate the report if possible.

MiquelRForgeFlow commented 3 years ago

You are welcome! I leave the _render thing to you :)