Closed MiquelRForgeFlow closed 3 years ago
Hello @sebalix
Here are some nice improvements:
What is pending:
What we obtain:
I would like you to merge this, and then later, in future PRs, try to fix those pending errors.
I already struggle with the issue regarding the v12 build, I don't think I want to pass more time on it... maybe we could disable the tests for v12 to get a green build, this version won't change anymore I suppose, if v11 and v13 builds are green, it's OK to say that the v12 is supported as well by the project.
Yeah, the issue with v12 is due to https://github.com/odoo/odoo/blob/12.0/addons/account/models/chart_template.py#L177 with an unexpected falsy company
. But disabling tests for v12, that would mean disabling a lot of tests, because many tests depend of that part. An alternative could be installing instead a module that not depends of account
and adapt the tests.
I try to be pragmatic with my time, if you want to fix it you are welcome :) Sadly I don't think I'll be able to pass more time on this issue, especially if we need to install other modules than sale
+account
to get working tests it'll be difficult.
Anyway, big thanks for your updates!
Regarding the issue for v14 _render
, we could try to use the HTTP controller to generate the report if possible.
You are welcome! I leave the _render thing to you :)
To check if something needs to be fixed.