Fix `check_value` method in fields.py

OCA / odoorpc

Python module to pilot your Odoo servers through JSON-RPC.

http://pythonhosted.org/OdooRPC/

GNU Lesser General Public License v3.0

231 stars 123 forks source link

Fix `check_value` method in fields.py #80

Closed matias-santurio closed 1 year ago

matias-santurio commented 1 year ago

If an Integer field is required, 0 should be a valid value.

oca-clabot commented 1 year ago

Hey @matias-santurio, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:

Matías Santurio matias.santurio@m.uy (no github login found)

Appreciation of efforts, OCA CLAbot

sebalix commented 1 year ago

Hello @matias-santurio , I fixed this issue with a better implementation there I think: https://github.com/OCA/odoorpc/pull/81 (moving the check on 0 to the relevant field classes, not the base one). I'm about to merge it so I'll close your PR. Thank you for spotting this issue!