search

OCA / operating-unit

Manage Operating Units in Odoo
GNU Affero General Public License v3.0
72 stars 237 forks source link

[15.0][MIG] account_asset_operating_unit #555

Closed Saran440 closed 1 year ago

Saran440 commented 1 year ago
OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow commented 1 year ago

/ocabot merge nobump

/ocabot migration account_asset_operating_unit

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-555-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at f06aab79d03b372fbc1fee6b021cdbc1ca75a406. Thanks a lot for contributing to OCA. ❤️

Saran440 commented 1 year ago

@AaronHForgeFlow Hello, May I ask you about filter OU.

Asset1 - OU-A Asset2 - No OU

Options

  1. Filter OU-A --> it will generate all OU-A and asset don't have operating unit (Asset1 and Asset2)
  2. Filter OU-A --> it will generate all OU-A only (Asset1). - https://github.com/OCA/operating-unit/pull/499

What is option that make sense for you?

AaronHForgeFlow commented 1 year ago

Typically, for access meaning if I have access to OU-A then I would see all assets OU-A and assets without OU.

However, for the purpose of filtering I think it makes more sense the second option. So yes, probably that PR needs to be forward ported.