search

OCA / operating-unit

Manage Operating Units in Odoo
GNU Affero General Public License v3.0
72 stars 237 forks source link

[15.0][ENH] hr_operating_unit: add OU to department #562

Open ps-tubtim opened 1 year ago

ps-tubtim commented 1 year ago

Adds an operating unit to the department

Selection_182

Saran440 commented 1 year ago

This PR fixed domain users in hr.employee

Selection_012

AaronHForgeFlow commented 1 year ago

I am not a user of this module, but this change seems legit. I would recommend to do a migration script to prefill the information in the department.

Saran440 commented 1 year ago

@AaronHForgeFlow I think this enhance shouldn't migration script because all department will default 1 OU

Example:

Case 1 (No script) Deparmtent A - No OU Deparmtent B - No OU Deparmtent C - No OU Deparmtent D - No OU

Case 2 (there is script) Deparmtent A - OU 1 Deparmtent B - OU 1 Deparmtent C - OU 1 Deparmtent D - OU 1

Case1 all user can see department Case2 user OU1 can see all department, it must change some department to correct OU I think case1 is makesense more than

What do you think?

AaronHForgeFlow commented 1 year ago

@Saran440 , I think that makes sense.

Would it make sense to put a restriction so the operating unit of the employee cannot be different from the operating unit of the department?

In any case I am not using this module and I prefer actual users to discuss this.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

github-actions[bot] commented 3 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.