search

OCA / operating-unit

Manage Operating Units in Odoo
GNU Affero General Public License v3.0
72 stars 237 forks source link

[16.0][MIG] operating_unit: migration to 16.0 #576

Closed huguesdk closed 1 year ago

huguesdk commented 1 year ago

/ocabot migration operating_unit

OCA-git-bot commented 1 year ago

Sorry @huguesdk you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

AaronHForgeFlow commented 1 year ago

/ocabot migration operating_unit

houssine78 commented 1 year ago

Hi @huguesdk, did you see the comment from Aaron ? Does it needs action from your side ? It's an improvement or this should work as the Aaron's expectations ?

Thank you :)

huguesdk commented 1 year ago

hi @houssine78. yes, i saw the comment, but thanks for the heads up! i did not intend to change the behavior, so if it does not work as in 15.0, then i need to fix it.

@AaronHForgeFlow: thanks for the review! do you know if this is something that works as expected in 15.0?

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

huguesdk commented 1 year ago

Functional review. I can remove operating unit for users except for the admin, If I remove the operating unit for the admin and I jump out and jump in again the user form view of the admin I see all OUs are assigned. Can't remove. Could you check that?

@AaronHForgeFlow: i tested in 15.0 and the behavior is the same. it comes from this code, which forces the users belonging to the operating_unit.group_manager_operating_unit group to have all operating units linked to them.

AaronHForgeFlow commented 1 year ago

Thanks for checking @huguesdk I think that is ok then. I just won't assign users to that group when they don't have access to all OU.

AaronHForgeFlow commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-576-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 60ca2d099f4c4bd9d5f31e588e0c3877d9b793e5. Thanks a lot for contributing to OCA. ❤️