[15.0][FIX] account_operating_unit: assign operating unit of the invoice journal has no operating unit no matter if OU are self balanced

AaronHForgeFlow commented 1 year ago

In this fix https://github.com/OCA/operating-unit/pull/582 the following criteria was implemented in regards operating units for payments:

self-balanced and set operating unit in journal = Outstanding Payment will add OU journal
self-balanced and not set operating unit in journal = Error
Not self-balanced and set operating unit in journal = Outstanding Payment will add OU journal
Not self-balanced and Not operating unit in journal = Outstanding Payment will add OU from invoices

After some testing, I thing the second criteria should not trigger an error. We should add the OU from invoices in the case OU are balanced and not operating unit in the journal. In previous versions it was possible to have a OU that is self-balanced and journals without operating unit, and the journal items for the payment had the operating unit of the invoice in that case.

@ForgeFlow

AaronHForgeFlow commented 11 months ago

Thank you @Saran440 , the runbot error was a temporary error with the runbot server. It is green now.

AaronHForgeFlow commented 11 months ago

/ocabot merge patch

OCA-git-bot commented 11 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-610-by-AaronHForgeFlow-bump-patch, awaiting test results.

OCA-git-bot commented 11 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 11 months ago

Congratulations, your PR was merged at 74e4a2ac03250b7ae2c1433a72977052f09c9a18. Thanks a lot for contributing to OCA. ❤️

OCA / operating-unit

[15.0][FIX] account_operating_unit: assign operating unit of the invoice journal has no operating unit no matter if OU are self balanced #610