search

OCA / operating-unit

Manage Operating Units in Odoo
GNU Affero General Public License v3.0
72 stars 238 forks source link

[13.0][IMP][mis_builder_operating_unit] Filter account entries not having operating unit #651

Closed robyf70 closed 5 months ago

robyf70 commented 7 months ago

Add explict filter for account entries without having set the operating unit"

AaronHForgeFlow commented 7 months ago

IMO all journal items should have an operating unit.

robyf70 commented 7 months ago

IMO all journal items should have an operating unit.

As I know you can still post account entries without OU, so it isn't mandatory field

AaronHForgeFlow commented 7 months ago

Yes, that is a good point. I will wait for others feedback.

robyf70 commented 7 months ago

I think the filter show be added in the main instance as well. If you are not in comparison mode users should be able to filter journals by no operating unit. Can you check this? LevelPrime#1

You are right! I will add this feature on the main instance as well

robyf70 commented 7 months ago

@AaronHForgeFlow I've just pushed the requested changes

robyf70 commented 6 months ago

@AaronHForgeFlow Do we need another review to be able to merge?

robyf70 commented 5 months ago

@MiquelRForgeFlow Are you able to review the last changes so we can finally get it merged?

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow commented 5 months ago

/ocabot merge minor

OCA-git-bot commented 5 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-651-by-AaronHForgeFlow-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-651-by-AaronHForgeFlow-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

AaronHForgeFlow commented 5 months ago

/ocabot merge minor

OCA-git-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-651-by-AaronHForgeFlow-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at deb35a4ab30725d3333d1c45a2306e3e57e0db0d. Thanks a lot for contributing to OCA. ❤️