OCA / operating-unit

Manage Operating Units in Odoo

GNU Affero General Public License v3.0

72 stars 238 forks source link

Closed jdidderen-nsi closed 2 months ago

jdidderen-nsi commented 4 months ago

Some changes (security rules) are based on changes made in the base modules https://github.com/OCA/operating-unit/pull/667

I removed domains on operating units fields for two reasons:

A operating unit manager is not necessarily assigned to a operating unit (https://github.com/OCA/operating-unit/blob/025e778a91e56bb83a52ec46dde19438965ed12c/operating_unit/models/res_users.py#L76) so in this case, the user id is not present in the user_ids field of the operating unit
The security rules already filter the units I can see.

Depends on:

AaronHForgeFlow commented 4 months ago

/ocabot migration product_operating_unit

yankinmax commented 4 months ago

you need to add test-requirements.txt file in operating-unit folder with such content

odoo-addon-operating_unit @ git+https://github.com/OCA/operating-unit.git@refs/pull/667/head#subdirectory=operating_unit

this should fix the build

yankinmax commented 3 months ago

@jdidderen-nsi thanks for the migration

gurneyalex commented 3 months ago

667 is now merged :smile_cat:

yankinmax commented 2 months ago

@jdidderen-nsi can you please remove dependency commit and rebase? operating_unit is merged:

jdidderen-nsi commented 2 months ago

@gurneyalex @yankinmax Rebased and good to go 👍

gurneyalex commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-668-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 1fe5bd06b83abac92dcfba6f9bb9f4d4c31f72ba. Thanks a lot for contributing to OCA. ❤️