search

OCA / operating-unit

Manage Operating Units in Odoo
GNU Affero General Public License v3.0
72 stars 238 forks source link

[MIG] account_operating_unit: Migration to 17.0 #670

Closed jdidderen-nsi closed 2 months ago

jdidderen-nsi commented 4 months ago

Depends on:

yankinmax commented 4 months ago

As soon as #667 and #669 is merged, everything should be good to go for this one.

why don't simply add tets-requirements.txt file including dependencies references? just name that commit with prefix DON'T MERGE

jdidderen-nsi commented 3 months ago

As soon as #667 and #669 is merged, everything should be good to go for this one.

why don't simply add tets-requirements.txt file including dependencies references? just name that commit with prefix DON'T MERGE

Thanks for the tip :)

yankinmax commented 2 months ago

@jdidderen-nsi can you please remove dependency commit and rebase? operating_unit is merged:

jdidderen-nsi commented 2 months ago

@yankinmax And it's rebased 👍

hbrunn commented 2 months ago

I was curious how you solved adding the operating unit to the analytic distribution widget, as I mentioned in the v16 migration, but it seems you didn't, correct? In my opinion this needs to be done for the migration to be complete

jdidderen-nsi commented 2 months ago

@hbrunn It was solved directly in the analytic_operating_unit module - https://github.com/OCA/operating-unit/pull/669

hbrunn commented 2 months ago

ah nice, thanks. That would then also be a good solution for v16, will backport that eventually

hbrunn commented 2 months ago

please also add https://github.com/OCA/operating-unit/pull/656/commits/d328870c717f758f1af0eab7e3da6de118c9d602 for higher test coverage

yankinmax commented 2 months ago

@jdidderen-nsi can you pls apply @hbrunn last suggestions?

jdidderen-nsi commented 2 months ago

please also cherry pick #685 so that we have feature parity

please also add d328870 for higher test coverage

@jdidderen-nsi can you pls apply @hbrunn last suggestions?

@hbrunn @yankinmax And it's done 👍

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hbrunn commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-670-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-670-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

AaronHForgeFlow commented 2 months ago

Issue with pre-commit on build, trying it again

/ocabot merge nobump

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-670-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 35838496f7ec0a0a1873f584db22a64e0dffdf16. Thanks a lot for contributing to OCA. ❤️