Open mohs8421 opened 7 months ago
In my local system I resolved this issue with the following small change:
diff --git a/partner_firstname/models/res_partner.py b/partner_firstname/models/res_partner.py
index d933e8055..64bb9966d 100644
--- a/partner_firstname/models/res_partner.py
+++ b/partner_firstname/models/res_partner.py
@@ -214,7 +214,7 @@ class ResPartner(models.Model):
correctly into the database. This can be called later too if needed.
"""
# Find records with empty firstname and lastname
- records = self.search([("firstname", "=", False), ("lastname", "=", False)])
+ records = self.search([("firstname", "=", False), ("lastname", "=", False), ("name", "!=", "")])
# Force calculations there
records._inverse_name()
I have to wonder if this repository is still maintained? I provided a bug report and a fix, and there is no reaction at all.
@mohs8421 thanks for your contrib.
I have to wonder if this repository is still maintained? I provided a bug report and a fix, and there is no reaction at all.
There are plenty of things to maintain as we have more than 230 repos and more than 5k modules :wink:
I'm not a maintainer of that module but I'll have a look at your PR.
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.
so how does contributing work here? Things don't get reviewed or merged and bots automatically tend to close contributions if they are left unattended? Isn't this behaviour actually harming for contributions in general?
When trying to install this module, I already get the following error:
It might be an issue referring to the general misconceptions about names also
Besides the edgecases, it might also be relevant for the system to be aware that the information about the firstname might simply be missing and only other details might be available.
Module
partner_firstname
To Reproduce
Affected versions: 16.0
Steps to reproduce the behavior:
Expected behavior The module should be installable