search

OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
202 stars 830 forks source link

[15.0][ADD] partner_readonly_security: New module #1772

Closed victoralmau closed 3 months ago

victoralmau commented 3 months ago

New module

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT48722

carolinafernandez-tecnativa commented 3 months ago

Functional review LGTM,

Only a suggestion, when user has no rights to create partner appears this error message

image

What do you think adding more friendly message for user like "Sorry, you are not allowed to create/edit partners. Please contact your admnistrator for further information"

Thanks!!

HaraldPanten commented 3 months ago

Hi Victor, are you sure that this can't be done by standard?

I'm not really sure if this module is really needed. Could you give us more details of the use case that you have?

THX.

pedrobaeza commented 3 months ago

@HaraldPanten we want that a sales manager doesn't edit partners. This can't be done with standard. Maybe the use case can be added to CONTEXT.rst though.

victoralmau commented 3 months ago

Changes done.

HaraldPanten commented 3 months ago

@HaraldPanten we want that a sales manager doesn't edit partners. This can't be done with standard. Maybe the use case can be added to CONTEXT.rst though.

Oh, understood! 👍

OCA-git-bot commented 3 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-1772-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 870521946c9b44c253d3a3261c125175b6f97322. Thanks a lot for contributing to OCA. ❤️