search

OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
205 stars 844 forks source link

[FIX] partner_multi_relation: Translation string couldn't be parsed correctly using str.format KeyError('kategori') issue #1783

Closed yankinmax closed 3 months ago

yankinmax commented 3 months ago

This fix is needed to stop having pre-commit failing on other PR's.

gurneyalex commented 3 months ago

I'm fine with the change but it has to be implemented through weblate, because the post merge scripts will revert the translations (unless I'm mistaken, maybe @sbidoul can confirm)

I made the change in weblate -> it should sync in a few hours.

yankinmax commented 3 months ago

@gurneyalex for me more important is to merge approved:

gurneyalex commented 3 months ago

It can't be merged now the CI will be red, and the oca bot will refuse to merge.

I've just changed the translation in the weblate UI, it should get merged in the next run of the cron, at which point the issue will be fix. Let's check this again tomorrow.

gurneyalex commented 3 months ago

https://github.com/OCA/partner-contact/commit/677e517bf1147b9735cf3d212d045b0f8b036b66 fixed the issue

sbidoul commented 3 months ago

I'm fine with the change but it has to be implemented through weblate, because the post merge scripts will revert the translations (unless I'm mistaken, maybe @sbidoul can confirm)

@gurneyalex weblate will not revert translations but may get into a git merge conflict if there are ongoing translations at the same time, and such merge conflicts are painful to resolve. That is why we strongly discourage pushing translations via git, but it can be done in some circumstances.

sbidoul commented 3 months ago

BTW, we should enable more checks in weblate to avoid these translation errors: https://github.com/OCA/oca-weblate-deployment/issues/12