OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
202 stars 830 forks source link

[17.0][MIG] base_location_nuts: Migration to 17.0 #1792

Closed salvorapi closed 1 month ago

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

FernandoRomera commented 1 month ago

@salvorapi Can you include this pr https://github.com/OCA/partner-contact/pull/1815

salvorapi commented 1 month ago

@salvorapi Can you include this pr #1815

Sure! There is some specific procedure to include PR or just merge the commit from #1815 ?

FernandoRomera commented 1 month ago

@salvorapi just merge the commit.

FernandoRomera commented 1 month ago

Hi @rafaelbn, @edlopen, Can you merge this PR.

HaraldPanten commented 1 month ago

/ocabot migration base_location_nuts

HaraldPanten commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1792-by-HaraldPanten-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

@HaraldPanten The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name partner-contact --branch 17.0 --addons-dir /tmp/tmpm49qjpcq --commit failed with output:

Both .md and .rst found for DESCRIPTION. Please remove one of /tmp/tmpm49qjpcq/base_location_nuts/readme/DESCRIPTION.rst or /tmp/tmpm49qjpcq/base_location_nuts/readme/DESCRIPTION.md.
HaraldPanten commented 1 month ago

@salvorapi Please, check failures. You have other binary files added by mistake in this PR.

THX.

salvorapi commented 1 month ago

@salvorapi Please, check failures. You have other binary files added by mistake in this PR.

THX.

done. I hope now it's ok. :)

FernandoRomera commented 1 month ago

@HaraldPanten Can you check and merge if all Ok?

edlopen commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

Sorry @edlopen you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

HaraldPanten commented 1 month ago

@HaraldPanten Can you check and merge if all Ok?

I still see the binary files:

Captura de Pantalla 2024-07-23 a las 10 08 26

FernandoRomera commented 1 month ago

@salvorapi can you meet @HaraldPanten requests?

salvorapi commented 1 month ago

@salvorapi can you meet @HaraldPanten requests?

@FernandoRomera sorry, but I didn't understand. These files are just removed (see the minus icon) from the commit.

@HaraldPanten do you ask me to adds it again ?

Salvo.

HaraldPanten commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1792-by-HaraldPanten-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at bba766ea848869aa29b4dae5718a62923abd7fbf. Thanks a lot for contributing to OCA. ❤️