search

OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
205 stars 844 forks source link

[17.0][FIX] partner_firstname : bug "create and edit" from invoice and sale order #1794

Closed rpinset closed 3 months ago

rpinset commented 3 months ago

Solve this issue https://github.com/OCA/partner-contact/issues/1757 Fix this PR https://github.com/OCA/partner-contact/pull/1725

@pedrobaeza I try again :)

pedrobaeza commented 3 months ago

You don't need an extra PR, but do a commit amend + push -f. Anyway, let's keep this new one. Take it into account for future occasions.

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BurkhalterY commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

Sorry @BurkhalterY you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

BurkhalterY commented 3 months ago

@pedrobaeza Could you merge please?

pedrobaeza commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-1794-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 714edd0cf020bc7346bc701a40d65003beaa0901. Thanks a lot for contributing to OCA. ❤️