OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
207 stars 851 forks source link

[17.0] partner_firstname: _check_name exception during saving address in website checkout form #1842

Open janbec opened 1 month ago

janbec commented 1 month ago

Module

partner_firstname There are two more bug reports #1638 and #1830 describing similar errors with different error messages.

Describe the bug

This is the translation of the error given by _check_name .

It seems both values firstname and lastname are false. It looks like _checkout_form_save writes to the partner with None values for firstname and lastname: grafik

checkout in checkout_form_save() is a dict with partner values in this case. The issue is fixed if I write firstname and lastname into checkout during that method, but there is probably a better way to do this.

To Reproduce

17.0 (I just pulled the most recent version)

Steps to reproduce the behavior:

  1. Get access and login with a portal user
  2. put something into a shopping cart
  3. try to checkout
  4. Fill out address field and click save
  5. Error