OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
214 stars 856 forks source link

[16.0][MIG] partner contact in several companies: Migration to 16.0 #1852

Open stephansainleger opened 1 month ago

stephansainleger commented 1 month ago

new PR replacing PR #1703 (wrong git manipulation...)

stephansainleger commented 1 month ago

Hi @legalsylvain ! After several misadventures with Git (including the unintentional closure of PR #1703 ...), I was finally able to properly follow the migration procedure for the module partner_contact_in_several_companies. Could you please let me know if everything is OK so we can finally complete this migration? Thank you!

PicchiSeba commented 1 month ago

I think we should take advantage of this occasion to comply with OCA module documentation.

The file README.md added in 9d8a0b2f093ffae0e56436d1598be49dea45d9a4 should be generated automatically. To do so we should move it to a directory called readme and change the extension from .md to .rst. In the same directory we should create two files called CONTRIBUTORS.rst and USAGE.rst, in the latter we must move the "Usage" section from README.rst

Then we can regenerate the "README.rst" file in the root folder with oca-gen-addon-readme

rousseldenis commented 1 month ago

/ocabot migration partner_contact_in_several_companies

tobru commented 3 weeks ago

Thank you so much for taking the time to migrate this add-on to Odoo 16. I just gave this PR a try in our Odoo 16, and it worked well so far. What I have seen is that in a Standalone contact in the "Other Positions" tab, the formatting seems to have some issues:

Screenshot_20241104_170303

Additionally, when clicking on this contact in the "Other Positions" tab, the pop-up is not really helpful, there is no mentioning to which other record this contact is related to. But maybe this was already the case in older versions and not related to the migration.

Screenshot_20241104_170644