OCA / partner-contact

Odoo Partner and Contact related addons
GNU Affero General Public License v3.0
207 stars 851 forks source link

Migration to version 13.0 #783

Open OCA-git-bot opened 5 years ago

OCA-git-bot commented 5 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

rven commented 5 years ago

Working on migration of partner_firstname https://github.com/OCA/partner-contact/pull/784

jeroenev commented 5 years ago

working on partner_contact_birthday, and partner_contact_personal_information_page

Laurent-Corron commented 4 years ago

working on:

ermannognan commented 4 years ago

Hi guys, I've seen jeroen7s:13.0-mig-partner_contact_personal_information_page. This migration has its last update more than 30 days ago (14 oct). In case I'd want to migrate to v 13.0 modules which depend from this one such as partner_contact_birthdate module, how can I proceed? I got to merge jeroen7s branch with my branch ermannognan:13.0-mig-partner_contact_birthdate? Can someone help me?

ermannognan commented 4 years ago

Excuse me again. I just saw on thread that jeroen7s is still working on module partner_conctact_birthdate(birthday?). I'm not really started to migrate that module, it was jus an example. I would like to start contributing but I am not very familiar with your conventions and how we share the tasks.

pedrobaeza commented 4 years ago

@ermannognan you have to review the corresponding PRs for getting them merged. For example, for partner_contact_personal_information_page, there's the PR ##788

https://odoo-community.org/page/review

mileo commented 4 years ago

Hi,

Can some one create the project 13.0 version of partner-contact at https://translation.odoo-community.org/

Best regards

sbidoul commented 4 years ago

@mileo I just updated weblate to pick up the 13.0 branch. They should appear in an hour or so.

mileo commented 4 years ago

@mileo I just updated weblate to pick up the 13.0 branch. They should appear in an hour or so.

100% translated to PT-BR

Laurent-Corron commented 4 years ago

partner_identification #815

kevinkhao commented 4 years ago

partner_deduplicate_acl #816 partner_deduplicate_by_website #818 partner_deduplicate_filter #819

StephanRozendaal commented 4 years ago

base_vat_sanitized #821 partner_address_street3 #823

poonlap commented 4 years ago

base_country_state_translatable #824

StephanRozendaal commented 4 years ago

partner_affiliate #827 partner_bank_active #828

kongrattapong commented 4 years ago

partner_capital https://github.com/OCA/partner-contact/pull/832

newtratip commented 4 years ago

partner_contact_birthdate https://github.com/OCA/partner-contact/pull/833

newtratip commented 4 years ago

partner_contact_job_position https://github.com/OCA/partner-contact/pull/834

newtratip commented 4 years ago

Ready for review #833 #834

newtratip commented 4 years ago

Working on partner_phone_extension https://github.com/OCA/partner-contact/pull/835

newtratip commented 4 years ago

Ready for review https://github.com/OCA/partner-contact/pull/835

newtratip commented 4 years ago

partner_employee_quantity https://github.com/OCA/partner-contact/pull/869

newtratip commented 4 years ago

partner_priority https://github.com/OCA/partner-contact/pull/870

newtratip commented 4 years ago

Working on partner_ref_unique https://github.com/OCA/partner-contact/pull/871

skeller1 commented 4 years ago

portal_partner_select_all #909

skeller1 commented 4 years ago

partner_disable_gravatar #911

Rad0van commented 4 years ago

partner_multi_relation #913 Needs some help though - described in PR.

skeller1 commented 4 years ago

partner_industry_secondary #916

tonygalmiche commented 4 years ago

Update to do :

Thank you in advance

Rad0van commented 4 years ago

Update to do :

  • base_country_state_translatable : #824
  • partner_coc : #848
  • partner_contact_birthdate : #833
  • partner_employee_quantity : #869
  • partner_identification : #815
  • partner_industry_secondary : #916
  • partner_multi_relation : #913
  • partner_phone_extension : #835
  • partner_priority : #870
  • partner_ref_unique : #871
  • portal_partner_select_all : #909

Thank you in advance

I'd love to finish #913 but need some help on how to replace with self.env.do_in_draft(). If anybody's willing to provide some guidance...

foliveira-odoogap commented 4 years ago

Hi, the module partner_contact_in_several_companies isn't in todo's list, but I would like to migrate it to version 13. Just let me know if I can working on it.

rousseldenis commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

Rad0van commented 4 years ago

Hi, the module partner_contact_in_several_companies isn't in todo's list, but I would like to migrate it to version 13. Just let me know if I can working on it.

As an alternative you can elegantly use partner_multi_relation

foliveira-odoogap commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

@rousseldenis This is my first contribution to OCA, I have the module migrated and tested too. As it is my first contribution, don't you mind to let me working on this one? I would appreciate.

Rad0van commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

@rousseldenis This is my first contribution to OCA, I have the module migrated and tested too. As it is my first contribution, don't you mind to let me working on this one? I would appreciate.

Let me answer from my recent experience. I did few of these as a learning Odoo/Python experience. There is ecosystem setup to guard the quality of the code, readability, etc... So you just try, submit PR and you will see. If you're not aware, here's how to do this: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 Hope it helps.

regispirard commented 4 years ago

@foliveira-odoogap just discussed this with @rousseldenis : you can make a P.R. with your version.

@Rad0van : partner_multi_relation can be usefull, thanks, but is less advanced than partner_contact_in_several_companies with which you can :

Rad0van commented 4 years ago

@foliveira-odoogap just discussed this with @rousseldenis : you can make a P.R. with your version.

@Rad0van : partner_multi_relation can be usefull, thanks, but is less advanced than partner_contact_in_several_companies with which you can :

  • specify more information (position, address, notes, ...)
  • other positions are displayed in kanban
  • other position are included in search

@regispirard will check it out in more detail. Thanx.

regispirard commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

@rousseldenis This is my first contribution to OCA, I have the module migrated and tested too. As it is my first contribution, don't you mind to let me working on this one? I would appreciate.

@foliveira-odoogap can you confirm you will make the pull request ? Thanks

Rad0van commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

@rousseldenis This is my first contribution to OCA, I have the module migrated and tested too. As it is my first contribution, don't you mind to let me working on this one? I would appreciate.

@foliveira-odoogap can you confirm you will make the pull request ? Thanks

@regispirard I do not want to interfere but not sure how @foliveira-odoogap could make the PR for / instead of you. Why don't you just do the PR yourself?

foliveira-odoogap commented 4 years ago

partner_contact_in_several_companies

Do you plan to do it as someone of ours has done it and will publish it

@rousseldenis This is my first contribution to OCA, I have the module migrated and tested too. As it is my first contribution, don't you mind to let me working on this one? I would appreciate.

@foliveira-odoogap can you confirm you will make the pull request ? Thanks

@regispirard I'll make the PR during this week!

joao-p-marques commented 4 years ago

Hi. I will migrate partner_ref_unique.

qgroulard commented 4 years ago

partner_email_check https://github.com/OCA/partner-contact/pull/989

joao-p-marques commented 4 years ago

partner_external_map https://github.com/OCA/partner-contact/pull/1007 (superseeds https://github.com/OCA/partner-contact/pull/813)

ulisesgamboa commented 3 years ago

Hi @NL66278 I am looking for partner_multirelation_tab for v13, do you have this is on your migration plans?

NL66278 commented 3 years ago

@ulisesgamboa I would like to, but my PR with improvements for 12.0, which I would like to base the migration to 13.0 and 14.0 on, is still waiting for merge of a dependent module in the web repository. It seems the maintenance of the web repository is not very active, and I have no rights there. See here: https://github.com/OCA/partner-contact/pull/979 and here: https://github.com/OCA/web/pull/1738

primes2h commented 2 years ago

partner_contact_birthplace https://github.com/OCA/partner-contact/pull/1197

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.