search

OCA / payroll

Odoo modules for payroll management
GNU Affero General Public License v3.0
75 stars 117 forks source link

[16.0][ADD] payroll_fetch_prev_month #144

Open norlinhenrik opened 7 months ago

OCA-git-bot commented 7 months ago

Hi @nimarosa, @appstogrow, some modules you are maintaining are being modified, check this out!

nimarosa commented 6 months ago

Hello Henrik, i think this can be on another module. I don't see why someone would need to fetch last month leaves. Maybe in another module will be okay if anyone want to use it. Now the payroll module have all the hooks to do that in external modules so i think we can do it that way.

Also if this conflicts with payroll_period it's another good reason to be another module, since a lot of people use payroll_period. Finally, i think changing the dates "on the fly" can lead to bugs in another modules depending on payroll too.

I see that you are changing the maintainer tag, feel free to do it in another PR and i will merge it.

norlinhenrik commented 3 months ago

I put the logic into a new module and added a hook in hr.payslip. @mtelahun @nimarosa What do you think?

mtelahun commented 3 months ago

Looks good to me.