search

OCA / pms

Property Management System on Odoo
GNU Affero General Public License v3.0
68 stars 83 forks source link

Possible dead code in BookingEngine. _compute_availability_results #225

Closed robinkeunen closed 7 months ago

robinkeunen commented 1 year ago

https://github.com/OCA/pms/blob/01d869b4697e04d0fa22429a1c511c5b5dbb76b6/pms/wizards/pms_booking_engine.py#L183-L185

_compute_availability_results is called when the dates are changed on the booking_engine. It gets the availabilities for each room_type from pms_property.availability and computes a bunch of ORM commands from it.

If I understand correctly, this bit of code is useless since record.availability_results = False is done at line 185 https://github.com/OCA/pms/blob/01d869b4697e04d0fa22429a1c511c5b5dbb76b6/pms/wizards/pms_booking_engine.py#L223-L225

robinkeunen commented 1 year ago

@carmenbianca @DarioLodeiros

github-actions[bot] commented 8 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.