search

OCA / pms

Property Management System on Odoo
GNU Affero General Public License v3.0
68 stars 83 forks source link

[ADD] checkbox to select all properties at once #240

Closed OsoTranquilo closed 11 months ago

OsoTranquilo commented 12 months ago

Add a checkbox to select all properties at once, filter properties by company, and update data in cookies and session.

bosd commented 11 months ago

Thanks for your contribution. It might need some work for the tests to pass.

I've noticed the red pre-commit status on your pr's. Maybe you could install pre-commit locally to detect them earlier?

How to install pre-commit locally: After running pre-commit install once in a git clone directory, lint checks are then run automatically when you commit locally so you can detect errors much earlier. Source: https://odoo-community.org/blog/news-updates-1/black-isort-pre-commit-97

OsoTranquilo commented 11 months ago

Thanks for your contribution. It might need some work for the tests to pass.

I've noticed the red pre-commit status on your pr's. Maybe you could install pre-commit locally to detect them earlier?

How to install pre-commit locally: After running pre-commit install once in a git clone directory, lint checks are then run automatically when you commit locally so you can detect errors much earlier. Source: https://odoo-community.org/blog/news-updates-1/black-isort-pre-commit-97

Thank you very much for the recommendation. I have tried to solve the pre-commit problem but I think the problem is not in my files. Can you help me and tell me what I can do? Thank you so much.

bosd commented 11 months ago

This error is related to the files in this PR. However not introduced by your commits:

image

This is indeed an very odd statement. https://github.com/OCA/pms/pull/240/files#diff-9a4f4d8be1a040a651a1aa3472956fc9b241eb85b893e5f2dba9ed00918f4433R991-R1009

Maybe this would this fix it? self.assertTrue(lines_availability_test_double) Propably better to make a seperate PR.

Currently pre-commit and unit tests are broken in this branch/repo. There are some PR's with an attempt to fix it. But there is quite a bit of work to be done.