[17.0][FIX] pos_lot_barcode: fix testcase

OCA / pos

GNU Affero General Public License v3.0

285 stars 602 forks source link

[17.0][FIX] pos_lot_barcode: fix testcase #1232

Closed chaule97 closed 2 months ago

chaule97 commented 2 months ago

as reported in some PRs (#1208, #1230, #1234) pos_lot_barcode tests were failing due a tour.
turns out the root cause if that the pos_lot_selection and pos_product_expirymodules have the same test case class name as the pos_lot_barcode module.
as a consequence, there was a conflict during the unittest TestSuite collection process.
Beside, I add ProductScreen.confirmOpeningPopup() step in order to confirm the opening of the session.

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 2 months ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1232-by-etobella-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1232-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

etobella commented 2 months ago

Well, it seems that the error is still raised after the changes :sob:

ivantodorovich commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1232-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at eec62aae5ecbedd18ab981855b616894f09f82af. Thanks a lot for contributing to OCA. ❤️