search

OCA / pos

GNU Affero General Public License v3.0
285 stars 602 forks source link

[FIX] pos_product_label: Avoid to show extra content field in different formats at PoS #1245

Closed miguelcb2003 closed 1 month ago

miguelcb2003 commented 1 month ago

In backend, this field dissapear automatically when you click any other format that is not '2x7xprice'. This is because it's the only format that allows to have extra content in its label. This is a video that shows this functionallity at backend:

backend.webm

Before this changes, that behaviour didn't work at PoS, making this field editable in all formats.

pos.webm

Now, with this changes the behaviour at PoS is the same than in backend, avoiding to modify the extra content field when it's not possible.

FL-556-3627

OCA-git-bot commented 1 month ago

Hi @ivantodorovich, some modules you are maintaining are being modified, check this out!

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

miguelcb2003 commented 1 month ago

Hi @ivantodorovich ! I add that because at PoS, this value does not update until confirm the action. If we want to hide or show the extra content dinamically we need the onchange function. Anyway, if you have any suggest to improve this let me know and I'll implement it. Thank you for the validation!

ivantodorovich commented 1 month ago

/ocabot merge patch

thanks!

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1245-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at e779233fd868bb1f57b7414a3c504c727b9dedc5. Thanks a lot for contributing to OCA. ❤️