search

OCA / product-configurator

Advanced Product Configurator (from the original Pledra project https://github.com/pledra/odoo-product-configurator)
GNU Affero General Public License v3.0
33 stars 78 forks source link

14.0 mig product configurator #1

Closed dreispt closed 3 years ago

dreispt commented 3 years ago

Migrate to 14.0 base product_configurator module, with history. Precommit applied, two issues need fixing (need help):

Chandresh-OSI commented 3 years ago

@dreispt Ready for the review. CC @bizzappdev @PCatinean

dreispt commented 3 years ago

@Chandresh-OSI Doing sanity checks, I get an error when opening the Product Configurator with the demo data installed: image

dreispt commented 3 years ago

I also see a few warnings on the Log file. Can these be fixed please?

2021-04-20 17:24:40,776 16186 WARNING 14-boti-0419 odoo.fields: Field product.attribute.custom_type: unknown parameter 'size', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2021-04-20 17:24:40,816 16186 WARNING 14-boti-0419 odoo.fields: Field product.config.line.value_ids: unknown parameter 'id1', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2021-04-20 17:24:40,816 16186 WARNING 14-boti-0419 odoo.fields: Field product.config.line.value_ids: unknown parameter 'id2', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2021-04-20 17:24:40,887 16186 INFO 14-boti-0419 odoo.modules.registry: module product_configurator: creating or updating database tables
2021-04-20 17:24:41,001 16186 WARNING 14-boti-0419 odoo.addons.base.models.ir_model: Two fields (name, config_name) of product.product() have the same label: Name.
2021-04-20 17:24:41,187 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/security/configurator_security.xml
2021-04-20 17:24:41,822 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/views/res_config_settings_view.xml
2021-04-20 17:24:42,068 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/data/menu_configurable_product.xml
2021-04-20 17:24:42,173 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/data/product_attribute.xml
2021-04-20 17:24:42,186 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/data/ir_sequence_data.xml
2021-04-20 17:24:42,193 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/data/ir_config_parameter_data.xml
2021-04-20 17:24:42,199 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/security/ir.model.access.csv
2021-04-20 17:24:42,557 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/views/assets.xml
2021-04-20 17:24:42,680 16186 INFO 14-boti-0419 odoo.modules.loading: loading product_configurator/views/product_view.xml
2021-04-20 17:24:43,055 16186 WARNING 14-boti-0419 odoo.models: @onchange('standard_price', 'activity_cost_ids', 'activity_cost_ids.standard_price') parameters must be field names
dreispt commented 3 years ago

@Chandresh-OSI I fixed the issues I found

dreispt commented 3 years ago

@Chandresh-OSI I don't think the wizard should look like this. I guess the "Attributes" field should not be visible, and the selection option should depend on the step we are at. Can you check?

image

Chandresh-OSI commented 3 years ago

@dreispt wizard looks like very similar to 13.0. I will check once again although.

dreispt commented 3 years ago

Yes, "Attributes" is there in v13, but after that the Fuel/Engine/... fields are not in the initial page,

dreispt commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at e6977ec8b44a29c81795ee6e7d7308f55ea7ea1f. Thanks a lot for contributing to OCA. ❤️