search

OCA / product-configurator

Advanced Product Configurator (from the original Pledra project https://github.com/pledra/odoo-product-configurator)
GNU Affero General Public License v3.0
33 stars 78 forks source link

[16.0][IMP] product_configurator: cleanup (pre-commit + reactivate tests) #133

Closed simahawk closed 1 month ago

simahawk commented 1 month ago

Applying changes using pre-commit settings from v17 to align as much as possible v16 and avoid conflicts in fwd/bkp :)

I started by cherry-picking linting-only related changes from https://github.com/OCA/product-configurator/pull/117 (@dreispt I did some magic to preserve your commit, I've just renamed it).

On top of that I added some more changes to make v17 linting happy and then ported to v16 and making its linting happy too.

In this way we should have less conflicts when fwd/bkp changes as v16 seems quite active now.

There are several changes on v17 that will be probably nice to port here and w/o this change it will be a hell.

Has been an hard work, but sounds good now :sweat_smile:

EDIT: I also restored the tests that were abandoned since v13 w/o fixing them all. At least we have a little bit more of test coverage.

OCA-git-bot commented 1 month ago

Hi @PCatinean, some modules you are maintaining are being modified, check this out!

simahawk commented 1 month ago

@SirAionTech could you help me w/ a review please?

simahawk commented 1 month ago

NOTE: I restored all tests but didn't spend time fixing the failing ones (luckily a minority). I've left FIXME comments where needed.

simahawk commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-133-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at ba2963dc805e0ee6feef39d5ea5f23cc7796c035. Thanks a lot for contributing to OCA. ❤️

SirAionTech commented 1 month ago

@SirAionTech could you help me w/ a review please?

Sorry I got here late, anyway good thing this got merged :rocket: