search

OCA / product-configurator

Advanced Product Configurator (from the original Pledra project https://github.com/pledra/odoo-product-configurator)
GNU Affero General Public License v3.0
33 stars 78 forks source link

[FIX][14.0] extra price/price computation for configurable products #52

Closed pledrateam closed 2 years ago

PCatinean commented 3 years ago

@DonatasV @gaikaz can you test this MR on your scenario described in https://github.com/OCA/product-configurator/pull/49 ?

gaikaz commented 3 years ago

Thank you so much for actually getting back with this! Will definitely test it! Hopefully tomorrow.

PCatinean commented 3 years ago

@pledrateam seems code coverage has failed due to the code removal, can we bump it up slightly so all tests are green?

DonatasV commented 3 years ago

By testing the scenario described in #49, we also found another bug with is related to product_configurator_sale module and the same pricelists... If sale order already has selected pricelist with, for example 50%, discount, then after we use configurator in SO, the price of product will be selected without discount. That happening because the price is selected from configurator session but ignores pricelist. (https://github.com/OCA/product-configurator/blob/14.0/product_configurator_sale/wizard/product_configurator.py#L26)

PCatinean commented 3 years ago

@DonatasV we should have fixed also the last issue you mentioned. Can you please confirm?

DonatasV commented 2 years ago

@PCatinean Sorry to keep you wait. I checked and everything work fine now.

PCatinean commented 2 years ago

/ocabot merge patch

OCA-git-bot commented 2 years ago

Sorry @PCatinean you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

PCatinean commented 2 years ago

@dreispt is the ocabot maintainer check case sensitive by chance?

dreispt commented 2 years ago

@PCatinean it could be the case, I can fix the maintainers key.

dreispt commented 2 years ago

After #54 is merged, you can rebase and try again.

PCatinean commented 2 years ago

/ocabot merge patch

OCA-git-bot commented 2 years ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-52-by-PCatinean-bump-patch, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at 4a499c1dab0723de72588099c76225c92559bf8b. Thanks a lot for contributing to OCA. ❤️