search

OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

12.0 add product_pack #1

Closed ernestotejeda closed 5 years ago

ernestotejeda commented 5 years ago

Supersedes https://github.com/OCA/product-attribute/pull/498

Cc @tecnativa

pedrobaeza commented 5 years ago

Please squash adjacent commits of the same author together to reduce a bit commit history.

Does the unfolding has been done? @legalsylvain what do you think about the unfolding of the pack_price_type field?

rafaelbn commented 5 years ago

https://github.com/OCA/product-attribute/pull/498

cc @jjscarafia @zaoral

rafaelbn commented 5 years ago

@sergio-teruel please

OCA-git-bot commented 5 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ernestotejeda commented 5 years ago

I have done the unfolding of the pack_price_type field as @Yajo proposed here https://github.com/OCA/product-attribute/pull/498#issuecomment-532720466 but I left the totalized Pack Type option instead of the proposed merged option and I added to the readme that it can be added later

ernestotejeda commented 5 years ago

Changes done

pedrobaeza commented 5 years ago

/ocabot merge

OCA-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-1-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot commented 5 years ago

Congratulations, your PR was merged at cd4596f3ba0a5c88033c50e8e666a1a60558e5e8. Thanks a lot for contributing to OCA. ❤️

jjscarafia commented 5 years ago

:clap::clap::clap::clap: thanks for the great work to you all!