OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

[14.0][FIX] product_pack: Compute directly the price on pricelists #106

Closed pedrobaeza closed 1 year ago

pedrobaeza commented 1 year ago

FW-port of #97

Steps to reproduce the problem:

That's because the computations done after calling price_compute in the pricelist engine modify the final returned price, so we don't call super on such cases and compute it directly.

@Tecnativa TT37977

OCA-git-bot commented 1 year ago

Hi @ernestotejeda, some modules you are maintaining are being modified, check this out!

pedrobaeza commented 1 year ago

@nicomacr @jjscarafia this is the fw-port. Please review for quick-merge of the full chain.

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-106-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-106-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-106-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 354234595d368dae46d08d59da835c1a2c3055e8. Thanks a lot for contributing to OCA. ❤️