[12.0][IMP] sale_product_pack add pack_modifiable in the sale order line.

[hparfr]

It's helpfull to know directly if the sale order line is editable.

If the sale order is edited from an api, onchange are not always triggered so having this field helps to raise an error.

And it can be used to display in the view that the line is not editable.

[OCA-git-bot]

Hi @ernestotejeda, some modules you are maintaining are being modified, check this out!

[ernestotejeda]

I think that being modifiable or not is a characteristic of the product class, not of the order line class. Image we try to modify a SOline and we get an exception and then we realize that the product has that option marked incorrectly, when we uncheck it to fix it we will have to delete and create the SOLine for this change to take effect, or remove the product and select it again. What do you think @pedrobaeza ? Wouldn't it be better to have a related field instead?

[hparfr]

Image we try to modify a SOline and we get an exception and then we realize that the product has that option marked incorrectly, when we uncheck it to fix it we will have to delete and create the SOLine for this change to take effect, or remove the product and select it again.

The product can be in other sale order as well. Or even multiple times in the same sale order and It will be not updated automatically.

[pedrobaeza]

Why the new field is not shown on the UI?

[hparfr]

Why the new field is not shown on the UI? Because there is already a lot of fields on the sale order lines views. For the moment I prefer letting the integrator to decide if he wants to display it and how (with color ? a logo?...)

[pedrobaeza]

Then I don't see any advantage on having the field ...

[hparfr]

Then I don't see any advantage on having the field ...

• It's easier to call sale_order_line.is_modifiable than sale_order_line.pack_parent_line_id.product_id.pack_modifiable
• Better perfs

[pedrobaeza]

That performance is not so critical in this case, taking into account that is not continuously checked and for sure will be in cache. Any other reason?

[hparfr]

Be more pythonic is not a reason good enough ?

I don't see drawbacks of having it as a field.

(BTW, I use it on e-commerce shop to know if the guy is allowed to change quantities on the line and to manage properly the unlink).

[pedrobaeza]

I prefer to provide whole set in the same PR (Odoo UI part).

[hparfr]

Added the field in the view, just for you @pedrobaeza

[hparfr]

Sorry to still be picky, but with this change, a migration script is required for existing sale order lines with pack that moves the value from product template to line. Can you please include it?

Yes you are ;-). I don't think it's worth the effort. Having some existing draft sale order without the flag is ok and there is no value of changing confirmed sale orders.

Please use always snake case for method variables

Fixed; thanks

[pedrobaeza]

OK, please squash commits and I'll merge.

[hparfr]

Thanks @pedrobaeza

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-12-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 0655c84a5b5e007297fba614823f23e6be3a36c6. Thanks a lot for contributing to OCA. ❤️