[16.0][MIG] sale_product_pack: Migration to 16.0

[FrancoMaxime]

This pull request is based on the closed pull request (https://github.com/OCA/product-pack/pull/104).

[rousseldenis]

/ocabot migration sale_product_pack

[sanrav]

I've tested 4 different pack configurations. Here are my results :

Testing not OK :

• Pack type = Non detailed :
  • Pack components not displayed in the SO and sales price of the pack on SO line = total price of components => OK
  • In V15, the field Sales price on the pack configuration displays automatically the total price of the components but not in V16. Maybe, it's better to keep the same functionality as in V15 and calculate automatically the sales price on the product.template
  • The price of the pack on the SO line is not updated when I choose a pricelist containing, for instance, a discount of 10% for this pack. I click on "Update prices" next to the pricelist on the SO but the price on the line doesn't change. Even if I choose first the pricelist before choosing my pack on the line, the price of the pack doesn't take into account the pricelist. I think we should take into account the pricelist for non detailed packs.
• Pack type = Detailed and Price = Totalized in main product :
  • Pack components displayed in the SO and sales price of the pack = total price of components (prices of the components not displayed in the SO) => OK
  • Same issues as above regarding the prices but in addition, when I click on "Update price" after changing the pricelist on the SO, ODOO updates the sales price of the components and displays the prices on the SO lines. It should not display the prices of the components.
• Pack type = Detailed and Price = Ignored :
  • Pack components displayed in the SO and sales price of the pack = the one defined on its product configuration (not linked with component prices). Prices of the components not displayed in the SO => OK
  • When I click on "Update price" after changing the pricelist on the SO, ODOO updates the sales price of the components and displays the prices on the SO lines. It should not display the prices of the components.

Testing OK :

• Pack type = Detailed and Price = Detailed per component :
  • Pack components displayed in the SO and sales price of the pack and of the components displayed on SO lines. Price of the pack are the one defined on its product configuration (not linked with component prices) => OK
  • Prices on SO lines properly updated with pricelist => OK

[FrancoMaxime]

Two new commits have been added. The first allowing product_pack to use pricelist, and the second allows you to correctly calculate the prices. Unit test have been updated to check if the computation of product_pack price after pricelist update works. (for each product_pack type.)

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[jjscarafia]

Hi @FrancoMaxime ! We're already using this PR for some customers, working ok except from the bug and fix proposed here https://github.com/acsone/product-pack/pull/1 Thanks!

[FrancoMaxime]

Hi @jjscarafia, i made a little comment on it.

[bealdav]

FInally mergeable ?

[JrAdhoc]

@FrancoMaxime @pedrobaeza Is this ready for merging??

[FrancoMaxime]

@JrAdhoc Hi, for me, it is :)

[nicolascol]

Hi! functional review LGTM +1 Can you merge it? @rousseldenis

[rousseldenis]

@FrancoMaxime Could you rearrange commits (essentially delete merge ones) ?

[FrancoMaxime]

@rousseldenis I did it.

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-121-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f5730ff4794da42ebed221c9980718624f241bd5. Thanks a lot for contributing to OCA. ❤️