search

OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

[16.0] [MIG] website_sale_product_pack: Migration to 16.0 #135

Closed alvaro-domatix closed 6 months ago

alvaro-domatix commented 1 year ago

Hi, @ernestotejeda @pedrobaeza !

I would appreciate if you could review this and #134.

pedrobaeza commented 1 year ago

/ocabot migration website_sale_product_pack

I'm not the most suitable for reviewing this. @chienandalu if you may?

liebana commented 1 year ago

Functional review, LGTM.

As an small improvement (maybe not here), if Pack Display Type is "Detailed" once we add the pack to the cart I think the number of items should be the sum of the child lines instead of the number of packs.

image

augusto-weiss commented 11 months ago

Hi @alvaro-domatix i'm testing this and looks good! But, I notice a problem with packs detailed per components. On website the price is computed in a wrong way. Do you have any idea about that ? I am working on that but didn't find a good fix yet! The problem is that somewhere the context "whole_price_pack" is lost

augusto-weiss commented 11 months ago

Hi @alvaro-domatix, @pedrobaeza and @chienandalu I added this pr #144 to fix the problem I mentioned before, could you review it? Thanks a lot!!

github-actions[bot] commented 7 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza commented 6 months ago

Superseded by #165