search

OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

[MIG] product_pack: Migration to 17.0 #154

Closed bruno-zanotti closed 5 months ago

jappi00 commented 9 months ago

Functional: LGTM

OCA-git-bot commented 9 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

gurneyalex commented 6 months ago

/ocabot merge nobump

OCA-git-bot commented 6 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-154-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot commented 6 months ago

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-154-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

bruno-zanotti commented 6 months ago

Hey @pedrobaeza @gurneyalex I that binary was added after pre-commit execution (7d81a85769503c54b64435a4c8e7ae05199acef5), not sure why... should I remove it?

NICO-SOLUTIONS commented 6 months ago

there are ongoing FIX PR´s for product_pack and website_sale_product_pack. For product_pack its just a small change but i think we should consider it in the migratroin to 17.

pedrobaeza commented 6 months ago

Yes, you should remove it. That should be something of pre-commit not cleaning caches.

bruno-zanotti commented 5 months ago

@pedrobaeza done!

@NICO-SOLUTIONS if the PRs are still open I think it is better to merge this migration as it is and then when the solution is merge in 16 make the forward port to 17

OCA-git-bot commented 5 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-154-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at b99e1de3b0112533550f3c88571fba6386a07327. Thanks a lot for contributing to OCA. ❤️