search

OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

12.0 add sale_product_pack #2

Closed ernestotejeda closed 4 years ago

ernestotejeda commented 5 years ago

Supersedes https://github.com/OCA/sale-workflow/pull/923

Depends on:

Cc @Tecnativa TT17735

ernestotejeda commented 5 years ago

Thank you @Trivedi-Vacha-SerpentCS , I've done the changes related to your comments in https://github.com/OCA/product-pack/pull/1

ernestotejeda commented 5 years ago

Ready to review

pedrobaeza commented 5 years ago

Please rebase

ernestotejeda commented 5 years ago

changes done

zaoral commented 5 years ago

Hi @ernestotejeda

We found out a bug in version 11.0 related to when a product pack an its components has different currencies.

Leave you here this PR https://github.com/ingadhoc/product/pull/260 with the changes we applied in order to fix it, please consider those changes to be integrates to this PR.

Best Regards

ernestotejeda commented 5 years ago

Changes done @pedrobaeza Thanks @zaoral , I already included those changes related to the currency difference

ernestotejeda commented 4 years ago

@zeroheure, changes done :+1:

pedrobaeza commented 4 years ago

@chienandalu you are missing #3

chienandalu commented 4 years ago

Sure I did. Thanks!

zeroheure commented 4 years ago

Text changes looks good for me