OCA / product-pack

Odoo modules related to product packs
GNU Affero General Public License v3.0
45 stars 126 forks source link

[13.0][MIG] sale_product_pack: Migration to 13.0 #27

Closed ernestotejeda closed 4 years ago

ernestotejeda commented 4 years ago

supersedes https://github.com/OCA/product-pack/pull/24

cc @Tecnativa TT24634

ernestotejeda commented 4 years ago

@jjscarafia could you review?.

pedrobaeza commented 4 years ago

Please squash administrative commits together and several translations that comes together from the same person.

pedrobaeza commented 4 years ago

@ernestotejeda I don't see your commit with extra changes. Have you included in @jjscarafia's one? They should be split.

ernestotejeda commented 4 years ago

Yes, I included my changes and the same commit. But, ok, I will divide into 2 commits

ernestotejeda commented 4 years ago

@pedrobaeza I have squashed administrative commits and I split the v13 migration commit into 2 commits.

ernestotejeda commented 4 years ago

@pedrobaeza , done. Check that.

pedrobaeza commented 4 years ago

/ocabot merge nobump

OCA-git-bot commented 4 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-27-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 4 years ago

Congratulations, your PR was merged at f5558061a376c0d4bb25b7f72dae71c2a5285005. Thanks a lot for contributing to OCA. ❤️

jjscarafia commented 4 years ago

thanks you both!