[ADD] website_sale_product_pack: New module - Githubissues

OCA / product-pack

Odoo modules related to product packs

GNU Affero General Public License v3.0

45 stars 126 forks source link

[ADD] website_sale_product_pack: New module #46

Closed chienandalu closed 2 years ago

chienandalu commented 3 years ago

Compatibility module between sale_product_pack and website_sale

cc @Tecnativa TT30385

chienandalu commented 3 years ago

@ernestotejeda could you review?

pedrobaeza commented 3 years ago

Ey, Travis goes to red now

chienandalu commented 3 years ago

:green_apple:

nicomacr commented 3 years ago

@chienandalu great work with this module. Really thanks We got a similar module here

I've check this PR and compare with our module and find that would be interesting to have this features in the module to handle the publish mechanism:

here we check for the products to add in a pack that all of them were published y if it not we alert. Maybe with a domain in the field could be better.
here we set for the pack lines in a pack to be publish or not from the parent pack. And the inverse case if one of the pack component becomes to unpublish we set the same for the parent pack. I think this part is better made in another method calling from write method.

I thinks this could be necessary because the mixing of a product pack published with somes of the components not, could be confuse and some bug related to this will be happened.

Any thoughts about that?

Thanks again.

chienandalu commented 3 years ago

Thanks @nicomacr I propose you to add your review in order to merge this one, and then I'll gladly review your PR with those improvements :slightly_smiling_face:

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-46-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 years ago

@chienandalu rebase to see the problem.

alvaro-domatix commented 3 years ago

We've detected a problem trying to use the packs on the website.

If you configure a product as a pack with pack_type = "detailed" and pack_component_price = "ignored" it apparently works while you do the cart until you try to pay. Once you enter the address information and click on "Next", the order sums the amount of all the components and the pack too.

Example:

Pack 1 (30€):

Comp 1 (20€)
Comp 2 (20€) Once you click on next after the address information the order's amount is 30€ + 20€ + 20€ = 70€

dreispt commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-46-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at e05a1f55b8296ed6353eefa575b85bb2fe4748f2. Thanks a lot for contributing to OCA. ❤️