[14.0][IMP] sale_product_pack: Set Unit Price to zero for product pack on sale order line when…

OCA / product-pack

Odoo modules related to product packs

GNU Affero General Public License v3.0

45 stars 126 forks source link

[14.0][IMP] sale_product_pack: Set Unit Price to zero for product pack on sale order line when… #89

Closed cvinh closed 1 year ago

cvinh commented 2 years ago

… pack component price is detailled Steps to reproduce :

set up a product pack with a price of 1000 EUR tax included : detailed pack type & detailed component price
set up 2 components products with different tax rates :
- 500 EUR 5% tax included
- 500 EUR 10% tax included
make a quotation with the product pack and save it

wrong behavior : the total of the sale order is 2000 EUR (each line shows the product price) right behavior : the total of the sale order should be 1000 EUR (the product pack price should be zero)

OCA-git-bot commented 2 years ago

Hi @ernestotejeda, some modules you are maintaining are being modified, check this out!

pedrobaeza commented 2 years ago

Can you explain the rationale of the change?

cvinh commented 2 years ago

Can you explain the rationale of the change?

Dear @pedrobaeza I updated the PR description. (I first thought that it was obvious) Best regards

cvinh commented 2 years ago

Seems OK. Can you add a test for this use case?

done

cvinh commented 2 years ago

@pedrobaeza I did another PR https://github.com/OCA/product-pack/pull/95 for improving tests with assertAlmostEqual like you suggested

pedrobaeza commented 2 years ago

You can close this one then, as the other contains both commits, isn't it?

cvinh commented 2 years ago

You can close this one then, as the other contains both commits, isn't it?

No sorry, I modified the other PR, I did 2 PR to separate cleanly, if you think I can have 2 commits in the same PR I can do it Please advice

pedrobaeza commented 2 years ago

Ok then

pedrobaeza commented 2 years ago

I have hit today by a problem with prices (on 13.0) and get to this: #97 , that also solves your problem.

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

cvinh commented 1 year ago

Hello can a psc member apply the 'no stale' label please ?

pedrobaeza commented 1 year ago

Closing this one as #97 solves it.