Closed carolinafernandez-tecnativa closed 5 months ago
Have you tried running the tests locally?
I did the test on a clean bd and I get the following error:
2024-05-22 11:27:27,567 1 ERROR devel odoo.addons.sale_variant_configurator.tests.test_sale_order: FAIL: TestSaleOrder.test_onchange_product_attribute_ids
Traceback (most recent call last):
File "/opt/odoo/auto/addons/sale_variant_configurator/tests/test_sale_order.py", line 145, in test_onchange_product_attribute_ids
self.assertEqual(line.price_unit + self.ptav_1.price_extra, 110)
AssertionError: 120.0 != 110
- self.ptav_1.price_extra
Could you please try again? I have checked and with this new changes in local with new database this issue is fixed, thanks!
On v16, AFAIK, there are no more onchanges in sale.order.line
. All are computed writable fields, so you shouldn't insist in making this to work with onchanges, but to adapt the mechanism overriding computed methods.
On v16, AFAIK, there are no more onchanges in
sale.order.line
. All are computed writable fields, so you shouldn't insist in making this to work with onchanges, but to adapt the mechanism overriding computed methods.On v16, AFAIK, there are no more onchanges in
sale.order.line
. All are computed writable fields, so you shouldn't insist in making this to work with onchanges, but to adapt the mechanism overriding computed methods.
The only one missing was _compute_name, could you please check it now?
/ocabot migration sale_variant_configurator
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-353-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 652eb8dd8cbab9da2974996bea4bd6779799020b. Thanks a lot for contributing to OCA. ❤️
@Tecnativa TT46599
@pedrobaeza @pilarvargas-tecnativa