Closed gabe-grinspan closed 4 months ago
/ocabot merge
Hi @gabriel-grinspan. Your command failed:
Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump
.
Ocabot commands
ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}
More information
/ocabot merge nobump
Sorry @gabriel-grinspan you are not allowed to merge.
To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.
If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers
key of its manifest.
@HaraldPanten Are you the right person to merge this? Please review.
@pedrobaeza
@pedrobaeza This should be good now.
@pedrobaeza I have amended my commit, updated the contributors, and run the pre-commit.
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-363-by-pedrobaeza-bump-minor, awaiting test results.
Congratulations, your PR was merged at 008ef4fda489fe33b2954030c313ba5280caaf70. Thanks a lot for contributing to OCA. ❤️
There is an issue in 17.0 where the Sales Price field is not editable in the quick view page found by navigating to variants from a parent product page. This module makes it such that the field is separated between products and variants. It should be easy to modify this field without having to navigate to the variants list page and search.
I believe this worked in previous versions, as the code seems to indicate there was a purpose for clearing
attrs
but in Odoo 17, Odoo removed that attribute and replaced it with options. As it is, options has nothing to do withreadonly
in this case.