OCA / program

GNU Affero General Public License v3.0
11 stars 26 forks source link

Fix new pylint style checks #9

Closed bwrsandman closed 9 years ago

bwrsandman commented 10 years ago

@dreispt @pedrobaeza This is to fix the new tests from https://github.com/OCA/maintainer-quality-tools/pull/127 so please take a look.

gurneyalex commented 10 years ago

:+1:

pedrobaeza commented 10 years ago

:+1:

@bwrsandman, do you think we fast-track this PR or follow strict OCA conventions?

bwrsandman commented 10 years ago

@pedrobaeza travis hasn't finished running, so follow that at least

pedrobaeza commented 10 years ago

But Travis error is unrelated, isn't it?

bwrsandman commented 10 years ago

@pedrobaeza brand new error. DO NOT MERGE

bwrsandman commented 10 years ago

@pedrobaeza see https://github.com/OCA/program/pull/9/files#r20305363 (outdated diff above) this is why we follow procedure even in rush cases like these ;)

pedrobaeza commented 10 years ago

OK, I agree, at least without the Travis blessing.

bwrsandman commented 10 years ago

:bow: Praise Travis!

coveralls commented 10 years ago

Coverage Status

Changes Unknown when pulling db47e0c51c0172249e1b5303516d51ccd5b15d6b on savoirfairelinux:pylint into \ on OCA:7.0**.