First Commit Scrum Project Module

[mohamedhabibchallouf]

Add Scrum module to project agile Branch

[elicoidal]

Actually it seems that the repo setup files have not been initiated. Can you create a PR to init the repo files, following example on https://github.com/OCA/business-requirement (for example). We are talking about:

• README.md
• travis.yml
• LICENSE file
• CONTRIBUTING.md
• oca_dependencies.txt

[bealdav]

@mohamedhabibchallouf thanks a lot for this super module

[pedrobaeza]

@hbrunn I don't know, as .travis.yml seems to be in place.

[hbrunn]

a user with admin rights needs to go to https://travis-ci.org/OCA/project-agile and turn it on, I don't have the permissions

[pedrobaeza]

Ouch, it was that! @dreispt, please check next time full "Create new PSC project" procedure, that includes this.

Done. Closing and reopening for triggering Travis.

[hbrunn]

@mohamedhabibchallouf I'm not such a fan of automated tools myself, so I never tried it, but there's https://github.com/OCA/maintainer-tools/blob/master/tools/autopep8_extended.py

[mohamedhabibchallouf]

@hbrunn i work on it now :)

[pnajman-modoolar]

Hi guys,

I'm really happy to see the first pull request here and I appreciate the effort.

In order to prevent any misunderstanding I would like to clarify that this pull request is not related, in any way, to the project_agile (a.k.a Odoo Scrummer) code which will be released here in the up coming days.

Here at Modoolar we are working to make modules compliant with the OCA coding standards and once we finish, we'll start making pull requests for each module (one by one) just as we agreed upon in the "Odoo Scrummer" mail thread.

Cheers, Petar Najman

[hbrunn]

but then this PR is the good place to agree on a data model for the basic entities. We can't have two scrum related modules, and first PR merged wins...

[dreispt]

@pedrobaeza Sure, just remember to share it with me.The doc I could find does not mention TravisCI.

@pnajman-modoolar @mohamedhabibchallouf I can see that we have two independently implemented scrum modules. There is no point in having two modules doing the same. We need to check what each does differently and on what they overlap.

[pedrobaeza]

@dreispt it's an internal OCA board task (https://odoo-community.org/web?#id=264&view_type=form&model=project.task&action=468&active_id=2), as it contains sensible information.

[hbrunn]

...and if it turns out that they have interesting but incongruent features, we should try hard to move as much as possible to a shared base module so that the whole set of modules stays compatible

[bealdav]

@pnajman-modoolar there was a real confusion here. Thanks to notice us. @mohamedhabibchallouf which additionnal feature brings your module ?

Thanks for your work

[dreispt]

I added the "Question" tag to remind us to compare with the Scrummer module, to be made available soon, before this can be merged.

[dreispt]

@elicoidal The dotfiles are there; the branch needs a rebase to have them included.

[hbrunn]

@mohamedhabibchallouf @HaojunZou @anderswallenquist In this PR, I identified quite striking similarities with the vertelab scrum version

Is this an innocent case of code borrowing/using some common ancestor and forgetting to attribute or is this a case of license violation?

@mohamedhabibchallouf please comment on this. In any case, you must be sure that the code you hand in is actually yours to give away. The other source being some free license is not enough, because by submitting code to the OCA you also push it under the OCA's CLA, which is an extra legal step.

[mohamedhabibchallouf]

@hbrunn Actually In Tenovar Ltd we are working on this module, since an early version (OpenERP 7), now I am pushing the code in his latest version (Odoo v10), I just discovered that there is a similarity with vertlab, In any case, I can confess, that the code I am pushing is a result of tenovar working, and its a free to use, we are pushing it because we believe in the Opensource and sharing knowledge values.

[hbrunn]

good to hear. I just want to avoid merging time bombs in the sense that if other people have a claim to code we in the OCA use, this will be a problem sooner or later. Can you trace it in your organization internally where the code originally comes from?

[hbrunn]

@pedrobaeza does the secret list also say something about runbot? Would be good I think to have this in place for the functional people to discuss the functional aspects of this

[pedrobaeza]

@hbrunn yes, the procedure includes 2 steps for runbot:

• Create a webhook in GitHub repository with runbot URL.
• Add the repository in our runbot instance.

@dreispt did you do both?

[dreispt]

@mohamedhabibchallouf Hmm, your review and retrospective field definitions are identical to Vertelab's, introduced in a 2015 commit...

Is there a chance someone borrowed this code? It is AGPL open source, so of course you can use it. However, authorship attribution is required by the license, otherwise it would be plagiarism. And the OCA has an additional requirement that the authors need to have signed the CLA. If this is so, we should add vertelab to the authors and ask them to agree with the CLA.

What do you think @mohamedhabibchallouf ?

[samirGuesmi]

@dreispt Hi, I would thank everyone here for the effort and checking, Here we should mention that the base Module, was done by Odoo SA, (OpenERP V6). Vertelab and others propably based on that module and start putting more functionalities and trying to cater for more Agile-Scrum values. As a Tenovar Ltd we did an effort on functional and technical side, Saying that does not mean that we are against adding more authors, we pushed it into OCA community to share our experience around Agile Scrum methodolgy. Contributors are more than welcome, and of course, will be added to the authors.

[hbrunn]

that this all derived from odoo's project_scrum somehow is clear and nobody questions this. That's also not the problem we're talking about here. The question is: Is this a further development of only odoo's sources or is this a derived work of @vertelab's derived work, which would force us to ask them for waiving their copyright or signing our CLA if we want to use the code. Alternative is to simply rewrite sections of code in question, preferably by a person who hasn't seen the original code before.

I pinged two of the authors involved in the other module in https://github.com/OCA/project-agile/pull/1#issuecomment-347465225, maybe they can shed light into this.

The similarity I've found was created long after Odoo SA deprecated the module, so to be honest my assumption is you grabbed this code some time in the 8 lifecycle and kept improving it. Absolutely no problem with that in the open source world, but unfortunately, that still doesn't make it yours in terms of license decisions. Please clarify.

[samirGuesmi]

@hbrunn Thanks, I will try to check the history of our Module.

Otherwise, following your logic, we need to ask Odoo SA , as well as the Python Software Foundation since we are using python for coding.

Again, our only intention is to share, an opensource, done by us from scratch or improved by us, to the community.

[robch2342]

@hbrunn For what it's worth, I have signed the ICLA, and I believe my boss (Anders Wallenquist) signed the CCLA for Vertel AB as well. If this is a derivative of our work then we would ofc want Vertel AB to be mentioned among the authors.

[hbrunn]

now, that's great to hear. Then we'll be fine one way or the other (@dreispt can you confirm the CCLA? I don't know if a humble OCA member can see this at all, what I know is that I don't know how), and I leave it to you to gather the evidence for the authorship. But then we're sure we don't pull in code of people who don't want it to be pulled in, that was my whole point. Thanks.

So back to technical stuff!

[dreispt]

I checked and Vertel AB has an ECLA, signed by CEO Anders Wallenquist.

[daramousk]

@mohamedhabibchallouf I have made a PR that fixes a lot of stuff (this module is seriously broken). Are you going to follow up on this PR or should I start a new one?

[hbrunn]

@daramousk please start a new one, this PR hasn't been updated for more than half a year

[hbrunn]

closing this in favor of #16 because of lack of activity and because we commit to get this done